Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First update on refactoring based on SearchBackend #270

Open
wants to merge 6 commits into
base: primary
Choose a base branch
from
Open

First update on refactoring based on SearchBackend #270

wants to merge 6 commits into from

Conversation

Firesphere
Copy link
Owner

Hi there and thank you for taking the time and effort to make a Pull Request

No, seriously, we are delighted you made time and effort to help us, even in the smallest way!

Please check the following

  • Have you opened an issue to discuss the feature and agree its general design?
  • Do you have a use case and, ideally, an example program using the feature?
  • Do you have tests covering 90%+ of the feature code (and, of course passing)
  • Have you written complete and accurate doc comments?
  • Have you updated the README or docs where needed?
  • Code is readable
  • Code is tested
  • I've read the Code of Conduct (Or, at least, I do believe I agree with it)
  • Frontend features don't look completely uncared for
  • Code is PSR-2 compliant
  • I'm fairly sure this is useful
  • I'm not just making this PR for HacktoberFest
  • You rock. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliot-sawyer elliot-sawyer Awaiting requested review from elliot-sawyer

@madmatt madmatt Awaiting requested review from madmatt

@marczhermo marczhermo Awaiting requested review from marczhermo

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Firesphere