[WIP] Feature/prevent session override #29

Firesphere · 2019-08-30T03:55:12Z

Needs tests

lhalaa · 2019-09-02T04:57:22Z

src/extensions/UserDefinedFormControllerExtension.php

+            $existing = PartialFormSubmission::get()->byID((int)$id);
+            if ($existing) {
+                // Check if it has started yet, we need to start a new one, if it has started
+                $startNew = $existing->isStarted();


If the partial form has started (like if there's a partial form in a different tab), then it will create a new one?

What do we do with cases like, in one tab you have partial page, in another tab is a new one? How do we manage the sessions?

lhalaa · 2019-09-02T05:09:33Z

src/extensions/UserDefinedFormControllerExtension.php

+            }
+
+            if ($startNew) {
+                $partialForm = PartialFormSubmission::create()->write();


Maybe move this to onAfterInit() so you can assign a Parent and UserDefinedForm from $this->owner->getData() when creating a new PartialFormSubmission. This will create another AccordionItems

Firesphere added 2 commits August 30, 2019 14:56

Start a clean partial submission if needed

f69b555

Slightly cleaner check and Ping check

4f8e85e

lhalaa reviewed Sep 2, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Feature/prevent session override #29

[WIP] Feature/prevent session override #29

Firesphere commented Aug 30, 2019

lhalaa Sep 2, 2019

lhalaa Sep 2, 2019 •

edited

Loading

[WIP] Feature/prevent session override #29

Are you sure you want to change the base?

[WIP] Feature/prevent session override #29

Conversation

Firesphere commented Aug 30, 2019

lhalaa Sep 2, 2019

Choose a reason for hiding this comment

lhalaa Sep 2, 2019 • edited Loading

Choose a reason for hiding this comment

lhalaa Sep 2, 2019 •

edited

Loading