Add onAfterInit tests

Firesphere · Jul 27, 2019 · 095b9ea · 095b9ea
1 parent ae673fe
commit 095b9ea
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/Extensions/ControllerCSPExtension.php b/src/Extensions/ControllerCSPExtension.php
@@ -211,7 +211,7 @@ protected function addInlineCSSPolicy($policy, $config): void
      */
     public function isAddPolicyHeaders(): bool
     {
-        return $this->addPolicyHeaders;
+        return $this->addPolicyHeaders ?? false;
     }
 
     /**

diff --git a/tests/unit/ControllerExtensionTest.php b/tests/unit/ControllerExtensionTest.php
@@ -10,7 +10,6 @@
 use SilverStripe\Control\Cookie;
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Control\NullHTTPRequest;
-use SilverStripe\Dev\Debug;
 use SilverStripe\Dev\SapphireTest;
 
 class ControllerExtensionTest extends SapphireTest
@@ -23,6 +22,13 @@ public function testInit()
         $extension = new ControllerCSPExtension();
         $extension->setOwner($controller);
 
+        $this->assertFalse($extension->isAddPolicyHeaders());
+
+        $extension->onBeforeInit();
+        $this->assertNull($extension->getNonce());
+        $extension->onAfterInit();
+        $this->assertArrayNotHasKey('content-security-policy-report-only', $controller->getResponse()->getHeaders());
+
         $request = new HTTPRequest('GET', '/', ['build-headers' => 'true']);
         $controller->setRequest($request);
         $extension->setOwner($controller);
@@ -41,5 +47,6 @@ public function testInit()
         $extension->onAfterInit();
 
         $this->assertArrayHasKey('content-security-policy-report-only', $controller->getResponse()->getHeaders());
+        $this->assertContains('self', $controller->getResponse()->getHeader('content-security-policy-report-only'));
     }
 }