Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing constructor when parsing XML into data class #401

Merged
merged 7 commits into from
Dec 22, 2020

Conversation

dinomite
Copy link
Member

See #396

@dinomite dinomite added the 2.12 label Dec 11, 2020
@dinomite dinomite added this to the 2.12.1 milestone Dec 11, 2020
@cowtowncoder
Copy link
Member

One question: is addition of 2.12.1 branch intentional? Patch versions are typically just tagged on release, and branches match minor versions. Nothing wrong in using branches for work, I just need to know I am using correct branches for release process.

@dinomite
Copy link
Member Author

@cowtowncoder Oh, 2.12.1 was intentional, but that's a good point. More important is conforming to the process that everything else uses, I'll get this re-pointed at 2.12 and ditch the .1 branch. 👍

@dinomite dinomite changed the base branch from 2.12.1 to 2.12 December 12, 2020 11:15
@cowtowncoder
Copy link
Member

@dinomite Ok yeah figured there was a reason as there are many ways to use tags & branches.

@dinomite dinomite closed this Dec 19, 2020
@dinomite dinomite reopened this Dec 19, 2020
@dinomite dinomite marked this pull request as ready for review December 22, 2020 11:05
@dinomite dinomite merged commit 02dedd0 into 2.12 Dec 22, 2020
@dinomite dinomite deleted the github-396-missing-xml-constructor branch December 22, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants