A model for Rust slices (and C array pointers) #225
+1,068
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahina-pro
commented
Oct 4, 2024
| : Lemma (is_slprop2 (is_split s p i left right)) | ||
| [SMTPat (is_slprop2 (is_split s p i left right))] | ||
|
|
||
| noeq type slice_pair (t: Type) = | SlicePair: (fst: slice t) -> (snd: slice t) -> slice_pair t |
There was a problem hiding this comment.
I added this type because Karamel refuses to extract functions returning F* pairs
There was a problem hiding this comment.
This is only an issue with the Rust backend, right? In my experience, C-karamel does pairs just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes:
Pulse.Lib.ArrayPtr, a library of C array pointers with subarray arithmetic, along with C extraction rules.Pulse.Lib.Slice, a library of Rust slices.Since
Pulse.Lib.Sliceis implemented on top ofPulse.Lib.ArrayPtr, slices can extract to C, with their lengths becoming explicit.Pulse.Lib.Slice.fstiis meant to model the following slice operations:op_Array_Index(resp.op_Array_Assignment) is modelingget_uncheckedfollowed by a read (resp. update)split false(resp.split true) is modelingsplit_at(resp.split_at_mut)copyis modelingcopy_from_sliceI intend those operations to be extracted by adding rules in Pulse2Rust (which is why they are not marked
inline_for_extraction, thus C extraction will produce explicit functions monomorphized by Karamel.) However, at this point, I have no idea how to do that, so this PR does not provide anything to extract slices to Rust. If anyone has any idea, please rise up! Thanks in advance!NOTE: Currently, this PR is done on top of Pulse commit c003b97, corresponding to the last known good Everest at project-everest/everest@064cc21