CPUID: Update to something a little more modern #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
force-pushed
the
update_cpuid
branch
from
2af1e75
to
572add9
Compare
lioncash
approved these changes
Sep 15, 2024
neobrain
reviewed
Sep 16, 2024
neobrain
reviewed
Sep 16, 2024
Previously reported as some old CPU without AVX and SSE4 and other things. Start advertising as something more modern that actually shipped with AVX2 and other features. Should help some modern libraries that do bad family and model checks rather that CPUID features checks. Also removes the silly `(ES)` tag from CPU-Z. Also moves generation in to a constexpr function that can actually range check these 4-bit and 8-bit values.
Sonicadvance1
force-pushed
the
update_cpuid
branch
from
572add9
to
09879bd
Compare
|
Switched over to struct bitfields instead to enforce the size limits. |
neobrain
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously reported as some old CPU without AVX and SSE4 and other things.
Start advertising as something more modern that actually shipped with AVX2 and other features. Should help some modern libraries that do bad family and model checks rather that CPUID features checks.
Also removes the silly
(ES)tag from CPU-Z.Also moves generation in to a constexpr function that can actually range check these 4-bit and 8-bit values.