Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lin ref in ase datasets #643

Merged
merged 1 commit into from
Apr 8, 2024
Merged

lin ref in ase datasets #643

merged 1 commit into from
Apr 8, 2024

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Apr 5, 2024

I think the linear reference should be computed in the models as part of #556 or in the trainer, but for now we can match the oc22_dataset, and deprecate this later.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 57.29%. Comparing base (be0f727) to head (c8ada66).

Files Patch % Lines
ocpmodels/datasets/ase_datasets.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   57.29%   57.29%   -0.01%     
==========================================
  Files         109      109              
  Lines       10300    10307       +7     
==========================================
+ Hits         5901     5905       +4     
- Misses       4399     4402       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anuroopsriram
Copy link
Collaborator

LGTM for now, but I agree that the linear referencing code should ideally be shared across all dataset and model types.

@lbluque lbluque added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit ed82408 Apr 8, 2024
5 checks passed
@lbluque lbluque deleted the ase-dataset-lin-ref branch April 11, 2024 18:39
levineds pushed a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants