fix: elng should be full box #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The elng box was errononously not reading/writing full box headers. This is now changed, but one can still read the old errononous type.
gastonmorixe
approved these changes
Jul 10, 2024
Comment on lines
+11
to
+25
| // Defined in ISO/IEC 14496-12 Section 8.4.6 | ||
| // It should be a full box, but was erronously implemented | ||
| // as a normal box. For backwards compatibility, the | ||
| // erronous box without full header can still be decoded. | ||
| // The method MissingFullBoxBytes() returns true if that is the case. | ||
| type ElngBox struct { | ||
| Language string | ||
| missingFullBox bool | ||
| Version byte | ||
| Flags uint32 | ||
| Language string | ||
| } | ||
|
|
||
| // MissingFullBoxBytes indicates that the box is errornously not including the 4 full box header bytes | ||
| func (b *ElngBox) MissingFullBoxBytes() bool { | ||
| return b.missingFullBox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
elngbox was errononously not reading/writing full box headers. This is now changed, but one can still read the old errononous type.This should solve the re-opened issue #245 where the
moovbox could not be parsed.