Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch autocompletion of file args and opts #7

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Feb 27, 2024

Here I debated making the code even shorter with autocompletion=lambda: [], which has the same results. I certainly did not want to import complete_path from EV, though, since this module does not actually depend on EV.

Copy link

CLI load time: 0:00.20
Pull Request HEAD: 019ce5d98ecdb250983eb80d88af8885f5ba8b8f
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1254 |     106380 |     typer.main
import time:       275 |     132116 |   typer
import time:       396 |     138325 | aligner.cli

@roedoejet
Copy link
Member

Here I debated making the code even shorter with autocompletion=lambda: [], which has the same results. I certainly did not want to import complete_path from EV, though, since this module does not actually depend on EV.

thanks for not making everyvoice a dependency here!

@joanise joanise merged commit 4a8e0f1 into main Feb 28, 2024
2 checks passed
@joanise joanise deleted the dev.ej/283.autocomplete-files branch February 28, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants