Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal CI validating that this repo stays Python 3.8 compatible #5

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Jan 25, 2024

Since we decided to stay compatible with Python 3.8, let's have CI minimally validate it remains true.

While doing this:

  • noticed that ctc-segmenter did not support -h, so added it;
  • noticed that this submodule does not use pydantic, and therefore the mypy pydantic plugin failed to even load;
  • bumped our actions to the latest since we're now getting warnings about Node 16 being end-of-life.

In everyvoice, we use conda to install Python, but this module does not need conda, and it takes longer to setup with it, so here I'm just using the regular action/setup-python.

Since we say this is 3.8 compatible but everyvoice needs 3.10,
let us have CI making sure mypy from Python 3.8 can still parse the code.

Also, ctc-segmenter should accept -h as synonym for --help.
Copy link

CLI load time: 0:00.27
Pull Request HEAD: 33c0b0ea7b4e27d5e63fb1319205adb7d829f261
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1047 |     111437 |         typer.rich_utils
import time:      1927 |     114346 |       typer.core
import time:      1460 |     139839 |     typer.main
import time:       406 |     174811 |   typer
import time:       490 |     182362 | aligner.cli

Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @joanise !

@joanise joanise merged commit 33c0b0e into main Jan 26, 2024
2 checks passed
@joanise joanise deleted the dev.ej/ci branch January 26, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants