Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): make this module compatible with typer 0.12 #11

Merged
merged 1 commit into from
May 31, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented May 31, 2024

typer 0.12 no longer supports the [all] extras, they're now just part of the default dependencies. To get them for typer < 0.12 and yet be compatible with 0.12 too, all we need to do is add rich and shellingham explicitly ourselves.

The version specification I chose for rich and shellingham are those in the current main branch of typer itself. These are very relaxed too, allowing pretty much any version in the last 3 or 4 years.

PR Goal?

Prepare the way to make EV compatible with typer 0.12, so we're not so tightly locked to an old version.

Related PRs?

https://github.com/roedoejet/clipdetect/pull/3

typer 0.12 no longer supports the [all] extras, they're now just part of the
default dependencies.  To get them for typer < 0.12 and yet be compatible with
0.12 too, all we need to do is add rich and shellingham explicitly ourselves.

The version specification I chose for rich and shellingham are those in the
current main branch of typer itself. These are very relaxed too, allowing
pretty much any version in the last 3 or 4 years.
@joanise joanise requested a review from roedoejet May 31, 2024 15:10
Copy link

CLI load time: 0:00.18
Pull Request HEAD: f28382090ec11121a6799a3c8d8f0347053ef996
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:       268 |     118469 |   typer
import time:       283 |     122498 | aligner.cli

Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks @joanise !

@roedoejet roedoejet merged commit b2a8e60 into main May 31, 2024
2 checks passed
@roedoejet roedoejet deleted the dev.ej/relax-typer branch May 31, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants