Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update submodules to add the PR template there too #428

Merged
merged 2 commits into from
May 17, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented May 14, 2024

PR Goal?

Broadcast our PR template in all EV repos

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.49%. Comparing base (110512c) to head (2dc8ae6).

❗ Current head 2dc8ae6 differs from pull request most recent head f4b4c61. Consider uploading reports for the commit f4b4c61 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   73.49%   73.49%           
=======================================
  Files          43       43           
  Lines        2852     2852           
  Branches      468      468           
=======================================
  Hits         2096     2096           
  Misses        671      671           
  Partials       85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 14, 2024

CLI load time: 0:00.29
Pull Request HEAD: 57df25aa6910b27a5d107e7f9aed6f120f4d0927
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:       748 |     102919 |       typer.rich_utils
import time:      2256 |     105959 |     typer.core
import time:       880 |     123439 |   typer.main
import time:       234 |     141935 | typer

Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea - I was routinely adding this. Thanks @joanise !

@joanise
Copy link
Member Author

joanise commented May 16, 2024

@roedoejet Please also review Related PRs
EveryVoiceTTS/DeepForcedAligner#21
EveryVoiceTTS/wav2vec2aligner#10
EveryVoiceTTS/HiFiGAN_iSTFT_lightning#32
EveryVoiceTTS/FastSpeech2_lightning#76

LOL. You'd think in the PR where I'm adding the question "Related PRs", I would have listed these... 🤷‍♂️

Copy link
Collaborator

@SamuelLarkin SamuelLarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joanise joanise merged commit 57df25a into main May 17, 2024
2 checks passed
@joanise joanise deleted the dev.ej/pr-template branch May 17, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants