Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in the manual about recovery near retention policy #980

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

andremagui
Copy link
Contributor

@andremagui andremagui commented Aug 8, 2024

This commit Closes: #200 .

It adds a note to the recovery section of the documentation manual. This note informs users about the risk of backup obsolescence and deletion during the recovery process, particularly when retention policy rules are enforced, and provides guidance on how to prevent this issue.

Initially, the team considered implementing an automatic solution for this problem. However, several concerns were raised, including the potential for unintended side effects during recovery, the existing keep feature designed to assist with backups, and the need for users to be fully aware of the implications and procedures during recovery—an operation often conducted under stressful situations.

References: BAR-222

@andremagui andremagui requested a review from a team as a code owner August 8, 2024 00:39
Copy link
Contributor

@barthisrael barthisrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to revisit this.

This implementation is fragile as it is because the WALs required by the recovery process to complete could be vanished once the KEEP is released.

We need to discuss a different approach.

@andremagui andremagui marked this pull request as draft August 8, 2024 12:30
@andremagui andremagui marked this pull request as ready for review August 23, 2024 18:18
@andremagui andremagui changed the title Add and release keep annotation to the backup for the recover operation Add note in the manual about recovery near retention policy Aug 23, 2024
This commit Closes#200. It is adding a note to the recovery
section in the documentation manual alerting the user about
the possibility of the backup getting obsolete while the
recovery process is ongoing and what to do to prevent that.

The team first thought about a solution that could handle this
automatically but many arguments were against this, specially
because it could introduce unwanted behaviour on recover and
the fact that `keep` feature is there to help.

References: BAR-222

Signed-off-by: Andre <andre.marchesini@enterprisedb.com>
Copy link
Contributor

@barthisrael barthisrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@barthisrael barthisrael merged commit 58b2653 into master Aug 29, 2024
7 of 8 checks passed
@barthisrael barthisrael deleted the dev/bar-222 branch August 29, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup was deleted during recovery process
3 participants