Events calendar view

[DaanVanVugt]

Summary of changes

• Add a calendar view to the event index page

Motivation and context

It can be a bit annoying to get an overview of what is happening on a specific day/week/month, and people are used to calendars.

Merge after #877

Screenshots

separate page:

Checklist

• I have read and followed the CONTRIBUTING guide.
• I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
  to license it to the TeSS codebase under the
  BSD license.

[fbacall]

Need some tests also

[DaanVanVugt]

Do we think the long events need an explicit year? they are very long, after all

[fbacall]

Sorry for late review, was on holiday.

I tried this out locally and have some comments:

• The calendar does not seem to load when deep linked (as opposed to clicking the tab), the loader spins endlessly.
• Does not integrate with the facets: Clicking a facet takes you back to the grid view. We hacked around this for the map view by updating the links in each facet when the map tab is activated. Could possibly do something similar or find a better approach. It should also take you back to the same month you were viewing.
• The calendar does not work for anonymous users (hence the test failure).
• The controls to switch to next/previous months could look better - maybe use the same styling as the pagination (with the arrow icons)?

[DaanVanVugt]

Sorry for late review, was on holiday.

I tried this out locally and have some comments:

* The calendar does not seem to load when deep linked (as opposed to clicking the tab), the loader spins endlessly.

* Does not integrate with the facets: Clicking a facet takes you back to the grid view. We hacked around this for the map view by updating the links in each facet when the map tab is activated. Could possibly do something similar or find a better approach. It should also take you back to the same month you were viewing.

* The calendar does not work for anonymous users (hence the test failure).

* The controls to switch to next/previous months could look better - maybe use the same styling as the pagination (with the arrow icons)?

All good points, and all fixed. Deeplinking works now, the currently selected month is kept when using facets, tests are fixed etc. One difficulty was with deeplinking to a specific month, but I think we can get by without that for now.

[DaanVanVugt]

I see now I need to change the way we query from SOLR, should do that before we can merge this.

[fbacall]

Is it necessary to do 2 solr queries?

[mikesndrs]

Right now it is done to make sure that the relevant events after the current day are not left out in favor of the past events if there are a lot of them. Looking for a better solution

[fbacall]

This doesn't seem to be a valid method. Maybe you could do something like @response.body.include?

[fbacall]

I was under the impression that the tab history JavaScript did this dynamically after the page loads

[fbacall]

Might be better to have something like [l(event.start, format: :long), l(event.end, format: :long)].compact.join(' - ')
to avoid a random - when only one date is present.

Or you could use the neatly_printed_date_range helper method.

[fbacall]

@mikesndrs are you making any more changes or should I merge?

[mikesndrs]

Pretty much done but if we ever find a better solution than 2 solr queries we will make a new PR