Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle language being blank (not just nil) #1006

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

fbacall
Copy link
Member

@fbacall fbacall commented Aug 1, 2024

Summary of changes

  • Change Event language validation to accept empty string
  • Allow language to be unset when editing an event

Motivation and context

When creating an event through the UI, if you don't select a language from the drop down, the parameter is passed as "", which causes validation to fail.

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

@fbacall fbacall merged commit f7070b3 into master Aug 2, 2024
11 checks passed
@fbacall fbacall deleted the allow-blank-language branch August 2, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant