Merge pull request #1018 from ElixirTeSS/lp-curator-role

Learning Path curator role

app/policies/learning_path_policy.rb

@@ -9,11 +9,11 @@ def update?
   end
 
   def manage?
-    curators_and_admin
+    curators_and_admin || @user&.has_role?(:learning_path_curator)
   end
 
   def create?
-    curators_and_admin
+    manage?
   end
 
   class Scope < Scope

config/data/roles.yml

@@ -13,4 +13,6 @@ default_user:
 basic_user: # Cannot create content
   title: Basic user
 unverified_user: # Content requires approval before being visible
-  title: New user
+  title: New user
+learning_path_curator:
+  title: Learning path curator

test/controllers/learning_paths_controller_test.rb

@@ -63,6 +63,10 @@ class LearningPathsControllerTest < ActionController::TestCase
     get :new
     assert_response :success
 
+    sign_in users(:learning_path_curator)
+    get :new
+    assert_response :success
+
     sign_in users(:admin)
     get :new
     assert_response :success
@@ -82,6 +86,12 @@ class LearningPathsControllerTest < ActionController::TestCase
     assert_response :success
   end
 
+  test 'should get edit for learning path curator' do
+    sign_in users(:learning_path_curator)
+    get :edit, params: { id: @learning_path }
+    assert_response :success
+  end
+
   test 'should get edit for admin' do
     #Owner of learning_path logged in = SUCCESS
     sign_in users(:admin)
@@ -105,6 +115,14 @@ class LearningPathsControllerTest < ActionController::TestCase
     assert_redirected_to learning_path_path(assigns(:learning_path))
   end
 
+  test 'should create learning_path for learning_path_curator' do
+    sign_in users(:learning_path_curator)
+    assert_difference('LearningPath.count') do
+      post :create, params: { learning_path: { title: @learning_path.title, description: @learning_path.description } }
+    end
+    assert_redirected_to learning_path_path(assigns(:learning_path))
+  end
+
   test 'should create learning_path for admin' do
     sign_in users(:admin)
     assert_difference('LearningPath.count') do
@@ -339,8 +357,8 @@ class LearningPathsControllerTest < ActionController::TestCase
     assert_select 'a.btn[href=?]', learning_path_path(@learning_path), count: 0 #No Edit
   end
 
-  test 'show action buttons when curator' do
-    sign_in users(:curator)
+  test 'show action buttons when learning_path_curator' do
+    sign_in users(:learning_path_curator)
 
     get :show, params: { id: @learning_path }
 
@@ -365,7 +383,7 @@ class LearningPathsControllerTest < ActionController::TestCase
   end
 
   test 'should allow access to private learning_paths if privileged' do
-    sign_in users(:curator)
+    sign_in users(:learning_path_curator)
     get :show, params: { id: learning_paths(:in_development_learning_path) }
     assert_response :success
   end

test/fixtures/roles.yml

@@ -23,3 +23,7 @@ basic_user:
 unverified_user: # Content requires approval before being visible
   name: unverified_user
   title: New user
+
+learning_path_curator:
+  name: learning_path_curator
+  title: Learning path curator

test/fixtures/users.yml

@@ -78,7 +78,6 @@ banned_user:
   role: user
   authentication_token: <%= Devise.friendly_token %>
 
-
 shadowbanned_user:
   username: Chad O'Band
   email: 'sbanned@notarealdomain.org'
@@ -151,3 +150,10 @@ upcase_username_and_email:
   email: 'MixedCaseEmail@example.com'
   encrypted_password: <%= Devise::Encryptor.digest(User, 'private') %>
   confirmed_at: <%= Time.zone.now %>
+
+learning_path_curator:
+  username: 'lp_cur8r'
+  email: 'lpc@example.com'
+  encrypted_password: 'learning_paths_curator_encrypted_password'
+  confirmed_at: <%= Time.zone.now %>
+  role: learning_path_curator