Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different var for nc/nf-config --includedir outputs #10

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Use different var for nc/nf-config --includedir outputs #10

merged 3 commits into from
Dec 22, 2023

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Dec 22, 2023

Fix some issues in FindNetCDF.cmake:

  • use different vars for nc/nf-config --includedirs outputs
  • fix typo INCLDE->INCLUDE
  • fix libs var name (was using flibs for C libraries)

Fixes #9

@jgfouca jgfouca self-assigned this Dec 22, 2023
jedwards4b
jedwards4b approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jgfouca jgfouca merged commit 3217894 into ESMCI:main Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedwards4b jedwards4b jedwards4b approved these changes

@jgfouca jgfouca jgfouca approved these changes

Assignees

@jgfouca jgfouca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible bug in FindNetCDF.cmake
3 participants
@bartgol @jedwards4b @jgfouca