Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New allometric equation options #392

Merged
merged 11 commits into from
Jul 24, 2024
Merged

New allometric equation options #392

merged 11 commits into from
Jul 24, 2024

Conversation

mpaiao
Copy link
Contributor

@mpaiao mpaiao commented Jun 12, 2023 •
edited
Loading

Included a few options in IALLOM.

Description

Revised IALLOM=3 and included a new IALLOM=5.

  1. For IALLOM=3, the main change is that leaf allometry is now also based on individual leaf area, which allows better compatibility with trait photo-plasticity.
  2. Added new IALLOM=5, which allows using the equation forms from IALLOM=3 but replaces the functional form for rooting depth to be the same as IALLOM=4.

Added a new sub-routine that calculates the vertical root distribution. This was originally calculated inside the plant hydrodynamics but it is now defined in allometry.f90 and the fractional distribution is now a cohort variable. This avoids creating inconsistencies in the future.

Collaborators

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Testing :

  • All new and existing tests passed.

mpaiao and others added 11 commits June 2, 2023 17:31
@mpaiao
A few allometry-related updates.
bc4468e 
1. Added new IALLOM option, which combines the leaf area allometry model from IALLOM=3 with
   the height-based root allometry from IALLOM=4.
2. Define the root profile as a cohort-based variable, and moved the calculation of root
   distribution to a specific allometric function.
3. Few minor bug fixes.
@mpaiao
Minor bug fix in ed_params.f90, one place was missing the IALLOM=5 se…
a8d3e4a 
…tting.
@mpaiao
More bug fixes, and updates to comments to reflect the correct refere…
02a8a3c 
…nces.
@mpaiao
Fix ed_opspec.F90 so the model accepts IALLOM = 5.
b2162b6
@mpaiao
Updated descriptions of the new IALLOM approaches in namelists and in…
291b246 
… ed_misc_coms.f90.
@mpaiao
Added call to update rooting distribution after cohort merging.
73181be
@mpaiao
Temporarily disabling mpi compilation from CI.
07e6d7b
@mpaiao
Update ED2IN variable description in the CI namelists.
cf1eeb2
@mpaiao
Merge branch 'master' into mpaiao-pr-new-allom
dd75773
@mpaiao
Merge branch 'master' into mpaiao-pr-new-allom
245a029
@mpaiao
Merge branch 'master' into mpaiao-pr-new-allom
8e7a210
@mpaiao mpaiao merged commit 48c99d8 into EDmodel:master Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpaiao