chore(deps): update module go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.44.0 [security] - autoclosed

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp	v0.37.0 -> v0.44.0

GitHub Vulnerability Alerts

CVE-2023-45142

Summary

This handler wrapper https://github.com/open-telemetry/opentelemetry-go-contrib/blob/5f7e6ad5a49b45df45f61a1deb29d7f1158032df/instrumentation/net/http/otelhttp/handler.go#L63-L65
out of the box adds labels

• http.user_agent
• http.method

that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent to it.

Details

HTTP header User-Agent or HTTP method for requests can be easily set by an attacker to be random and long. The library internally uses httpconv.ServerRequest that records every value for HTTP method and User-Agent.

PoC

Send many requests with long randomly generated HTTP methods or/and User agents (e.g. a million) and observe how memory consumption increases during it.

Impact

In order to be affected, the program has to configure a metrics pipeline, use otelhttp.NewHandler wrapper, and does not filter any unknown HTTP methods or User agents on the level of CDN, LB, previous middleware, etc.

Others

It is similar to already reported vulnerabilities

• GHSA-5r5m-65gx-7vrh (open-telemetry/opentelemetry-go-contrib)
• GHSA-cg3q-j54f-5p7p (prometheus/client_golang)

Workaround for affected versions

As a workaround to stop being affected otelhttp.WithFilter() can be used, but it requires manual careful configuration to not log certain requests entirely.

For convenience and safe usage of this library, it should by default mark with the label unknown non-standard HTTP methods and User agents to show that such requests were made but do not increase cardinality. In case someone wants to stay with the current behavior, library API should allow to enable it.

The other possibility is to disable HTTP metrics instrumentation by passing otelhttp.WithMeterProvider option with noop.NewMeterProvider.

Solution provided by upgrading

In PR https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277, released with package version 0.44.0, the values collected for attribute http.request.method were changed to be restricted to a set of well-known values and other high cardinality attributes were removed.

References

• https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277
• https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.19.0

---

Memory exhaustion in go.opentelemetry.io/contrib/instrumentation

CVE-2022-21698 / CVE-2023-25151 / CVE-2023-45142 / GHSA-5r5m-65gx-7vrh / GHSA-cg3q-j54f-5p7p / GHSA-rcjv-mgp8-qvmr / GO-2022-0322 / GO-2023-1546 / GO-2023-2113

More information

Details

Memory exhaustion in go.opentelemetry.io/contrib/instrumentation

Severity

Unknown

References

• https://github.com/open-telemetry/opentelemetry-go-contrib/security/advisories/GHSA-rcjv-mgp8-qvmr
• https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277

This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).

---

OpenTelemetry-Go Contrib vulnerable to denial of service in otelhttp due to unbound cardinality metrics

CVE-2022-21698 / CVE-2023-25151 / CVE-2023-45142 / GHSA-5r5m-65gx-7vrh / GHSA-cg3q-j54f-5p7p / GHSA-rcjv-mgp8-qvmr / GO-2022-0322 / GO-2023-1546 / GO-2023-2113

More information

Details

Summary

This handler wrapper https://github.com/open-telemetry/opentelemetry-go-contrib/blob/5f7e6ad5a49b45df45f61a1deb29d7f1158032df/instrumentation/net/http/otelhttp/handler.go#L63-L65
out of the box adds labels

• http.user_agent
• http.method

that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent to it.

Details

HTTP header User-Agent or HTTP method for requests can be easily set by an attacker to be random and long. The library internally uses httpconv.ServerRequest that records every value for HTTP method and User-Agent.

PoC

Send many requests with long randomly generated HTTP methods or/and User agents (e.g. a million) and observe how memory consumption increases during it.

Impact

In order to be affected, the program has to configure a metrics pipeline, use otelhttp.NewHandler wrapper, and does not filter any unknown HTTP methods or User agents on the level of CDN, LB, previous middleware, etc.

Others

It is similar to already reported vulnerabilities

• GHSA-5r5m-65gx-7vrh (open-telemetry/opentelemetry-go-contrib)
• GHSA-cg3q-j54f-5p7p (prometheus/client_golang)

Workaround for affected versions

As a workaround to stop being affected otelhttp.WithFilter() can be used, but it requires manual careful configuration to not log certain requests entirely.

For convenience and safe usage of this library, it should by default mark with the label unknown non-standard HTTP methods and User agents to show that such requests were made but do not increase cardinality. In case someone wants to stay with the current behavior, library API should allow to enable it.

The other possibility is to disable HTTP metrics instrumentation by passing otelhttp.WithMeterProvider option with noop.NewMeterProvider.

Solution provided by upgrading

In PR https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277, released with package version 0.44.0, the values collected for attribute http.request.method were changed to be restricted to a set of well-known values and other high cardinality attributes were removed.

References

• https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277
• https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.19.0

Severity

• CVSS Score: 7.5 / 10 (High)
• Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

References

• https://github.com/open-telemetry/opentelemetry-go-contrib/security/advisories/GHSA-5r5m-65gx-7vrh
• https://github.com/open-telemetry/opentelemetry-go-contrib/security/advisories/GHSA-rcjv-mgp8-qvmr
• https://nvd.nist.gov/vuln/detail/CVE-2023-45142
• https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277
• https://github.com/advisories/GHSA-cg3q-j54f-5p7p
• https://github.com/open-telemetry/opentelemetry-go-contrib
• https://github.com/open-telemetry/opentelemetry-go-contrib/blob/5f7e6ad5a49b45df45f61a1deb29d7f1158032df/instrumentation/net/http/otelhttp/handler.go#L63-L65
• https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.19.0
• https://github.com/open-telemetry/opentelemetry-go/blob/38e1b499c3da3107694ad2660b3888eee9c8b896/semconv/internal/v2/http.go#L223
• https://github.com/open-telemetry/opentelemetry-go/blob/v1.12.0/semconv/internal/v2/http.go#L159
• https://lists.fedoraproject.org/archives/list/package-announce@lists.fedoraproject.org/message/2UTRJ54INZG3OC2FTAN6AFB2RYNY2GAD

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).

---

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[renovate]

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum

Command failed: go get -d -t ./...
go: downloading k8s.io/apimachinery v0.27.4
go: downloading sigs.k8s.io/controller-runtime v0.15.1
go: downloading github.com/fluxcd/pkg/runtime v0.42.0
go: downloading github.com/go-logr/logr v1.4.1
go: downloading k8s.io/api v0.27.4
go: downloading k8s.io/client-go v0.27.4
go: downloading github.com/spf13/pflag v1.0.5
go: downloading go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0
go: downloading go.opentelemetry.io/otel v1.18.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.11.2
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.11.2
go: downloading go.opentelemetry.io/otel/sdk v1.11.2
go: downloading google.golang.org/grpc v1.62.1
go: downloading github.com/onsi/gomega v1.32.0
go: downloading github.com/gogo/protobuf v1.3.2
go: downloading github.com/google/gofuzz v1.2.0
go: downloading k8s.io/klog/v2 v2.100.1
go: downloading sigs.k8s.io/structured-merge-diff/v4 v4.2.3
go: downloading github.com/fluxcd/pkg/apis/meta v1.1.2
go: downloading sigs.k8s.io/cli-utils v0.35.0
go: downloading golang.org/x/net v0.20.0
go: downloading go.uber.org/zap v1.25.0
go: downloading github.com/evanphx/json-patch/v5 v5.6.0
go: downloading github.com/evanphx/json-patch v5.6.0+incompatible
go: downloading github.com/felixge/httpsnoop v1.0.3
go: downloading go.opentelemetry.io/otel/metric v1.18.0
go: downloading go.opentelemetry.io/otel/trace v1.18.0
go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: downloading k8s.io/utils v0.0.0-20230209194617-a36077c30491
go: downloading go.opentelemetry.io/proto/otlp v0.19.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.11.2
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240123012728-ef4313101c80
go: downloading golang.org/x/sys v0.16.0
go: downloading google.golang.org/genproto v0.0.0-20240123012728-ef4313101c80
go: downloading github.com/google/go-cmp v0.6.0
go: downloading github.com/golang/protobuf v1.5.3
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd
go: downloading github.com/json-iterator/go v1.1.12
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading github.com/imdario/mergo v0.3.13
go: downloading golang.org/x/term v0.16.0
go: downloading k8s.io/kubectl v0.26.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/prometheus/client_golang v1.16.0
go: downloading golang.org/x/time v0.3.0
go: downloading go.uber.org/multierr v1.10.0
go: downloading github.com/go-logr/zapr v1.2.4
go: downloading k8s.io/kube-openapi v0.0.0-20230501164219-8b0f38b5fd1f
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading github.com/cenkalti/backoff/v4 v4.2.0
go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.7.0
go: downloading google.golang.org/protobuf v1.33.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading golang.org/x/oauth2 v0.16.0
go: downloading github.com/google/gnostic v0.6.9
go: downloading github.com/spf13/cobra v1.6.1
go: downloading k8s.io/cli-runtime v0.26.0
go: downloading k8s.io/component-base v0.27.4
go: downloading sigs.k8s.io/kustomize/kyaml v0.13.9
go: downloading sigs.k8s.io/yaml v1.3.0
go: downloading gomodules.xyz/jsonpatch/v2 v2.3.0
go: downloading k8s.io/apiextensions-apiserver v0.27.3
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.2.0
go: downloading github.com/prometheus/client_model v0.4.0
go: downloading github.com/prometheus/common v0.42.0
go: downloading github.com/prometheus/procfs v0.10.1
go: downloading github.com/google/uuid v1.6.0
go: downloading golang.org/x/text v0.14.0
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20240123012728-ef4313101c80
go: downloading github.com/inconshreveable/mousetrap v1.0.1
go: downloading sigs.k8s.io/kustomize/api v0.12.1
go: downloading github.com/chai2010/gettext-go v1.0.2
go: downloading github.com/MakeNowJust/heredoc v1.0.0
go: downloading github.com/mitchellh/go-wordwrap v1.0.1
go: downloading github.com/russross/blackfriday/v2 v2.1.0
go: downloading github.com/exponent-io/jsonpath v0.0.0-20210407135951-1de76d718b3f
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.4
go: downloading github.com/fsnotify/fsnotify v1.6.0
go: downloading google.golang.org/appengine v1.6.8
go: downloading github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822
go: downloading github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de
go: downloading github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79
go: downloading github.com/peterbourgon/diskv v2.0.1+incompatible
go: downloading github.com/go-openapi/jsonreference v0.20.1
go: downloading github.com/go-openapi/swag v0.22.3
go: downloading github.com/moby/term v0.0.0-20221205130635-1aeaba878587
go: downloading github.com/go-errors/errors v1.4.2
go: downloading github.com/emicklei/go-restful/v3 v3.10.0
go: downloading github.com/google/btree v1.1.2
go: downloading github.com/mailru/easyjson v0.7.7
go: downloading github.com/go-openapi/jsonpointer v0.19.6
go: downloading github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
go: downloading github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00
go: downloading github.com/xlab/treeprint v1.1.0
go: downloading github.com/josharian/intern v1.0.0
go: downloading github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1
go: downloading github.com/moby/spdystream v0.2.0
go: downloading go.starlark.net v0.0.0-20221028183056-acb66ad56dd2
go: downloading go.opentelemetry.io/otel v1.24.0
go: downloading go.opentelemetry.io v0.1.0
go: downloading go.opentelemetry.io/otel/exporters/otlp v0.20.1
go: github.com/DoodleScheduling/webhook-controller/internal/otelsetup imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
	go.opentelemetry.io/otel/exporters/otlp/internal: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/DoodleScheduling/webhook-controller/internal/otelsetup imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
	go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig

[renovate]

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum

Command failed: go get -d -t ./...
go: downloading k8s.io/apimachinery v0.27.4
go: downloading sigs.k8s.io/controller-runtime v0.15.1
go: downloading github.com/fluxcd/pkg/runtime v0.42.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0
go: downloading k8s.io/api v0.27.4
go: downloading k8s.io/client-go v0.27.4
go: downloading go.opentelemetry.io/otel v1.18.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.11.2
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.11.2
go: downloading go.opentelemetry.io/otel/sdk v1.11.2
go: downloading google.golang.org/grpc v1.64.1
go: downloading github.com/go-logr/logr v1.4.2
go: downloading github.com/onsi/gomega v1.34.1
go: downloading k8s.io/klog/v2 v2.100.1
go: downloading github.com/gogo/protobuf v1.3.2
go: downloading github.com/google/gofuzz v1.2.0
go: downloading sigs.k8s.io/structured-merge-diff/v4 v4.2.3
go: downloading github.com/fluxcd/pkg/apis/meta v1.1.2
go: downloading sigs.k8s.io/cli-utils v0.35.0
go: downloading golang.org/x/net v0.27.0
go: downloading go.uber.org/zap v1.25.0
go: downloading github.com/felixge/httpsnoop v1.0.3
go: downloading go.opentelemetry.io/otel/metric v1.18.0
go: downloading go.opentelemetry.io/otel/trace v1.18.0
go: downloading github.com/evanphx/json-patch/v5 v5.6.0
go: downloading github.com/evanphx/json-patch v5.6.0+incompatible
go: downloading go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.11.2
go: downloading go.opentelemetry.io/proto/otlp v0.19.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237
go: downloading google.golang.org/genproto v0.0.0-20240123012728-ef4313101c80
go: downloading golang.org/x/sys v0.22.0
go: downloading github.com/google/go-cmp v0.6.0
go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: downloading k8s.io/utils v0.0.0-20230209194617-a36077c30491
go: downloading google.golang.org/protobuf v1.34.1
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd
go: downloading github.com/imdario/mergo v0.3.13
go: downloading golang.org/x/term v0.22.0
go: downloading github.com/json-iterator/go v1.1.12
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading k8s.io/kubectl v0.26.0
go: downloading github.com/prometheus/client_golang v1.16.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading golang.org/x/time v0.3.0
go: downloading go.uber.org/multierr v1.10.0
go: downloading github.com/go-logr/zapr v1.2.4
go: downloading k8s.io/kube-openapi v0.0.0-20230501164219-8b0f38b5fd1f
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading github.com/cenkalti/backoff/v4 v4.2.0
go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.7.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading golang.org/x/oauth2 v0.18.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/spf13/cobra v1.6.1
go: downloading k8s.io/cli-runtime v0.26.0
go: downloading k8s.io/component-base v0.27.4
go: downloading sigs.k8s.io/kustomize/kyaml v0.13.9
go: downloading sigs.k8s.io/yaml v1.3.0
go: downloading github.com/golang/protobuf v1.5.4
go: downloading github.com/google/gnostic v0.6.9
go: downloading gomodules.xyz/jsonpatch/v2 v2.3.0
go: downloading k8s.io/apiextensions-apiserver v0.27.3
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.2.0
go: downloading github.com/prometheus/client_model v0.4.0
go: downloading github.com/prometheus/common v0.42.0
go: downloading github.com/prometheus/procfs v0.10.1
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20240318140521-94a12d6c2237
go: downloading golang.org/x/text v0.16.0
go: downloading golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56
go: downloading github.com/google/uuid v1.6.0
go: downloading github.com/inconshreveable/mousetrap v1.0.1
go: downloading sigs.k8s.io/kustomize/api v0.12.1
go: downloading github.com/chai2010/gettext-go v1.0.2
go: downloading github.com/MakeNowJust/heredoc v1.0.0
go: downloading github.com/mitchellh/go-wordwrap v1.0.1
go: downloading github.com/russross/blackfriday/v2 v2.1.0
go: downloading github.com/exponent-io/jsonpath v0.0.0-20210407135951-1de76d718b3f
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.4
go: downloading github.com/fsnotify/fsnotify v1.6.0
go: downloading google.golang.org/appengine v1.6.8
go: downloading github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de
go: downloading github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79
go: downloading github.com/peterbourgon/diskv v2.0.1+incompatible
go: downloading github.com/go-openapi/jsonreference v0.20.1
go: downloading github.com/go-openapi/swag v0.22.3
go: downloading github.com/moby/term v0.0.0-20221205130635-1aeaba878587
go: downloading github.com/go-errors/errors v1.4.2
go: downloading github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822
go: downloading github.com/google/btree v1.1.2
go: downloading github.com/go-openapi/jsonpointer v0.19.6
go: downloading github.com/mailru/easyjson v0.7.7
go: downloading github.com/emicklei/go-restful/v3 v3.10.0
go: downloading github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
go: downloading github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00
go: downloading github.com/xlab/treeprint v1.1.0
go: downloading github.com/josharian/intern v1.0.0
go: downloading github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1
go: downloading github.com/moby/spdystream v0.2.0
go: downloading go.starlark.net v0.0.0-20221028183056-acb66ad56dd2
go: downloading go.opentelemetry.io/otel v1.28.0
go: downloading go.opentelemetry.io/otel/exporters/otlp v0.20.1
go: downloading go.opentelemetry.io v0.1.0
go: github.com/DoodleScheduling/webhook-controller/internal/otelsetup imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
	go.opentelemetry.io/otel/exporters/otlp/internal: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/DoodleScheduling/webhook-controller/internal/otelsetup imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
	go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig