Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Combo Records #410

Merged
merged 4 commits into from
Jul 26, 2023
Merged

feat: Added Combo Records #410

merged 4 commits into from
Jul 26, 2023

Conversation

b805rohit
Copy link
Contributor

@b805rohit b805rohit commented Jul 24, 2023 •
edited
Loading

feat: Combo Records

pawel-kow
pawel-kow requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK.
Some templates have groups on a single records, which might not be needed.

Generally - the updated templates should get a new higher version.

@b805rohit b805rohit requested a review from pawel-kow July 26, 2023 06:13
pawel-kow
pawel-kow approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pawel-kow pawel-kow added this pull request to the merge queue Jul 26, 2023
Merged via the queue into Domain-Connect:master with commit 2281e81 Jul 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawel-kow pawel-kow pawel-kow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b805rohit @pawel-kow