Create goentri.com.hotmart.json #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-kow
requested changes
Jul 11, 2023
pawel-kow
requested changes
Jul 11, 2023
goentri.com.hotmart-subdomains.json
Outdated
| "description": "Allows user to easily set up dkim record using Entri", | ||
| "syncPubKeyDomain": "goentri.com", | ||
| "syncRedirectDomain": "api.goentri.com, goentri.com, entri.com, app.entri.com,app.goentri.com", | ||
| "variableDescription": "cnamePointsTo is the URL to where the subdomain is pointed and target is to where the root domains has to be pointed", |
There was a problem hiding this comment.
sure about that the templates are not mixed up? This description tells about root domain and the service id is "subdomain"
There was a problem hiding this comment.
Maybe my description is not the best, the redirect is to redirect the root domain to the subdomain considering that the root domain is not pointed to anywhere in this case.
There was a problem hiding this comment.
But I deleted the Redirect anyway, they will not need that.
| "description": "Allows user to easily set up dkim record using Entri", | ||
| "syncPubKeyDomain": "goentri.com", | ||
| "syncRedirectDomain": "api.goentri.com, goentri.com, entri.com, app.entri.com,app.goentri.com", | ||
| "variableDescription": "primaryIp is the IP, cnamehost is the host for the CNAME and cnamePointsTo is the URL to where the subdomain is pointed ", |
There was a problem hiding this comment.
and here subdomain is mentioned, the template looks like a root domain template with redirect.
There was a problem hiding this comment.
and here the subdomain means the subdomains the user is creating, www for example.
pawel-kow
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.