Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#180) Remove dependency on pkg_resources in favour of importlib #181

Merged
merged 1 commit into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/workflows/services/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from __future__ import annotations

import pkg_resources
from importlib.metadata import entry_points


def lookup(service: str):
Expand All @@ -25,10 +25,7 @@ def get_known_services():
setattr(
get_known_services,
"cache",
{
e.name: e.load
for e in pkg_resources.iter_entry_points("workflows.services")
},
{e.name: e.load for e in entry_points()["workflows.services"]},
)
register = get_known_services.cache.copy()
return register
8 changes: 2 additions & 6 deletions src/workflows/transport/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@

import argparse
import optparse
from importlib.metadata import entry_points
from typing import TYPE_CHECKING, Type

import pkg_resources

if TYPE_CHECKING:
from .common_transport import CommonTransport

Expand Down Expand Up @@ -61,9 +60,6 @@ def get_known_transports() -> dict[str, Type[CommonTransport]]:
setattr(
get_known_transports,
"cache",
{
e.name: e.load()
for e in pkg_resources.iter_entry_points("workflows.transport")
},
{e.name: e.load() for e in entry_points()["workflows.transport"]},
)
return get_known_transports.cache.copy() # type: ignore
13 changes: 13 additions & 0 deletions tests/services/test.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@
from __future__ import annotations

import workflows.services
from workflows.services.common_service import CommonService


def test_known_services_is_a_dictionary():
"""Check services register build in CommonService."""
assert isinstance(workflows.services.get_known_services(), dict)


def test_enumerate_services():
"""Verify we can discover the installed services."""
services = workflows.services.get_known_services()
assert services.keys() == {
"SampleConsumer",
"SampleProducer",
"SampleTxn",
"SampleTxnProducer",
}
assert all([issubclass(service(), CommonService) for service in services.values()])
14 changes: 13 additions & 1 deletion tests/transport/test.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,23 @@
from __future__ import annotations

import workflows.transport
from workflows.transport.common_transport import CommonTransport


def test_known_transports_is_a_dictionary():
"""Check transport register build in CommonTransport."""
assert isinstance(workflows.transport.get_known_transports(), dict)
transports = workflows.transport.get_known_transports()
print(transports)
assert isinstance(transports, dict)


def test_enumerate_transports():
"""Verify we can discover the installed transports."""
transports = workflows.transport.get_known_transports()
assert transports.keys() == {"OfflineTransport", "PikaTransport", "StompTransport"}
assert all(
[issubclass(transport, CommonTransport) for transport in transports.values()]
)


def test_load_any_transport():
Expand Down