Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

three new methods, disableEvents, disablePicker and destroyNodes #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,30 @@ Example:
});
</script>

**`ColorPicker.prototype.disablePicker(false)`**

Disables Picker - removes its events and, if false is passed, deletes its nodes. (Default: false)

Example:

ColorPicker.prototype.disablePicker(false)

**`ColorPicker.prototype.disableEvents()`**

Disables all events of a picker - doesn't remove any elements.

Example:

ColorPicker.prototype.disableEvents(true)

**`ColorPicker.prototype.destroyNodes()`**

Removes all nodes from color picker (slider and picker).

Example:

ColorPicker.prototype.destroyNodes()


**`ColorPicker.prototype.setHsv(hsv)`**

Expand All @@ -71,6 +95,7 @@ Example:

**`ColorPicker.prototype.setHex(hex)`**


Sets HEX value.

Example:
Expand Down
81 changes: 68 additions & 13 deletions colorpicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
'</div>'

].join('');

var mousedown = false;
var eventListeners = {};

/**
* Return mouse position relative to the element el.
Expand Down Expand Up @@ -298,8 +301,31 @@
enableDragging(this, this.pickerElement, pickerListener(this, this.pickerElement));
};

function removeEventListener(element, event, listener) {

if (element.detachEvent) {

element.detachEvent('on' + event, listener);

} else if (element.removeEventListener) {

element.removeEventListener(event, listener, false);

}
}

function addEventListener(element, event, listener) {


if (!eventListeners[element.className || element.id]) {
eventListeners[element.className || element.id] = {};
}

if (!eventListeners[element.className || element.id][event]) {
eventListeners[element.className || element.id][event] = [];
}

eventListeners[element.className || element.id][event] = [element, listener];

if (element.attachEvent) {

element.attachEvent('on' + event, listener);
Expand All @@ -316,23 +342,52 @@
* @param {DOMElement} element HSV slide element or HSV picker element.
* @param {Function} listener Function that will be called whenever mouse is dragged over the element with event object as argument.
*/

function setMousedownToTrue(e){ mousedown = true; }
function setMousedownToFalse(e) { mousedown = false; }
function activateListener(e, listener) { if(mousedown) listener(e); }

function enableDragging(ctx, element, listener) {

var mousedown = false;

addEventListener(element, 'mousedown', function(evt) { mousedown = true; });
addEventListener(element, 'mouseup', function(evt) { mousedown = false; });
addEventListener(element, 'mouseout', function(evt) { mousedown = false; });
addEventListener(element, 'mousemove', function(evt) {

if (mousedown) {

listener(evt);
}
});
addEventListener(element, 'mousedown', setMousedownToTrue);
addEventListener(element, 'mouseup', setMousedownToFalse);
addEventListener(element, 'mouseout', setMousedownToFalse);
addEventListener(element, 'mousemove', function(e) { activateListener(e, listener); });
}

function disableDragging(element, listener) {
removeEventListener(element, 'mousedown', setMousedownToTrue);
removeEventListener(element, 'mouseup', setMousedownToFalse);
removeEventListener(element, 'mouseout', setMousedownToFalse);
removeEventListener(element, 'mousemove', function(e) { activateListener(e, listener); });
}



ColorPicker.prototype.disableEvents = function() {
var nodeKeys = Object.keys(eventListeners);
nodeKeys.forEach(function(nodeKey) {
var eventKeys = Object.keys(eventListeners[nodeKey]);
eventKeys.forEach(function(eventKey){
removeEventListener(eventListeners[nodeKey][eventKey][0], eventKey, eventListeners[nodeKey][eventKey][1]);
delete eventListeners[nodeKey][eventKey];
});
});
}

ColorPicker.prototype.destroyNodes = function() {
this.slideElement.parentNode.removeChild(this.slideElement);
this.pickerElement.parentNode.removeChild(this.pickerElement);
}

ColorPicker.prototype.disablePicker = function(destroyNodes){

this.disableEvents();
if (!destroyNodes) {
this.destroyNodes();
}
}

ColorPicker.hsv2rgb = function(hsv) {
var rgbHex = hsv2rgb(hsv);
delete rgbHex.hex;
Expand Down
2 changes: 1 addition & 1 deletion examples/basic.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<script type="text/javascript">

ColorPicker(
var ColorPicker = new ColorPicker(

document.getElementById('slider'),
document.getElementById('picker'),
Expand Down