Integrate catadog image as proxy service between agent and library #3958
+48
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-09-30 19:52:39 Comparing candidate commit 821b829 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
sarahchen6
force-pushed
the
sarahchen6/integrate-catadog-as-proxy
branch
from
20fc0da
to
4c5b6cc
Compare
sarahchen6
force-pushed
the
sarahchen6/integrate-catadog-as-proxy
branch
from
4c5b6cc
to
821b829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR integrates the catadog image in the
docker-compose.ymlas a proxy service between the library andddagent.Motivation:
Catadog is a tool for development, testing, and diagnosis. It helps validate reliability and adds value to the repository by ...
Additional Notes:
Currently, the
testagentports need to be changed explicitly from${DD_TRACE_AGENT_PORT}to9126in order for thedocker-compose.ymlto run.How to test the change?
Unsure? Have a question? Request a review!