Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions system-tests workflow #3879

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

y9v
Copy link
Member

@y9v y9v commented Aug 30, 2024

What does this PR do?
Fixes permissions for system-tests Github Workflow.

Motivation:
System tests failing for PR #3849
https://github.com/DataDog/dd-trace-rb/actions/runs/10633708151/job/29479572745?pr=3849

Additional Notes:
Similar to #3878

How to test the change?
System tests should not fail.

@y9v y9v self-assigned this Aug 30, 2024
@y9v y9v requested a review from a team as a code owner August 30, 2024 14:06
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Aug 30, 2024
We need write permissions to push images to registry.
@y9v y9v force-pushed the fix-system-tests-workflow-permissions branch from f185605 to ad5c466 Compare August 30, 2024 14:09
@lloeki lloeki merged commit 9e00232 into master Aug 30, 2024
163 of 167 checks passed
@lloeki lloeki deleted the fix-system-tests-workflow-permissions branch August 30, 2024 14:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (18dafe3) to head (ad5c466).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3879      +/-   ##
==========================================
- Coverage   97.86%   97.85%   -0.01%     
==========================================
  Files        1277     1277              
  Lines       76394    76394              
  Branches     3744     3744              
==========================================
- Hits        74762    74759       -3     
- Misses       1632     1635       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko added this to the 2.4.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants