Pawel plesniak/drunc op mon #18
Conversation
sync with develop
| class OpMonPublisher: | ||
| def __init__( | ||
| self, | ||
| topic:str, |
There was a problem hiding this comment.
I would like this to be the default_topic rather than just topic. The reason being that we envision the possibility of using multiple topics at some point so the algorithm that selects the topic given a metric at the moment is just returning the default, but it might not be the case for long
| application = application, | ||
| substructure = substructure | ||
| ) | ||
| t = Timestamp() |
There was a problem hiding this comment.
The timestamp should be the first thing happening.
| case fd.CPPTYPE_BOOL: | ||
| formatted_OpMonValue.boolean_value = value | ||
| case fd.CPPTYPE_STRING: | ||
| formatted_OpMonValue.string_value = value |
There was a problem hiding this comment.
We need to handle the case in which the type is a message itself.
There was a problem hiding this comment.
The equivalent C++ is https://github.com/DUNE-DAQ/opmonlib/blob/721d3fcb21fe087cddf14cb877ff6da514ae26d2/src/Utils.cpp#L84-L90 The rest of the code has to be handled accordingly.
| @@ -0,0 +1,17 @@ | |||
| class OpMonFunction : | |||
There was a problem hiding this comment.
Is there a reason why this was extracted into a separate file?
Otherwise I would prefer to restore as it was. The reason being that the file was supposed to be unique to simplify the construction of the microservice: https://github.com/DUNE-DAQ/microservices/blob/5a8182e9459e7f451eff6aed4da4dd06ccdc2eb5/dockerfiles/microservices-dependencies.dockerfile#L44
| def execute(self, e : entry.OpMonEntry ) : | ||
| self.function(e) | ||
|
|
||
| from kafkaopmon import OpMonFunction |
There was a problem hiding this comment.
See previous note on this extraction
mroda88
added
enhancement
Adds a python handle to convert messages into a OpMonEntry format.
Notes