Do not change the contents of a std::set within a range-for loop, as it #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can invalidate the iterators used for loop control.
bieryAtFnal
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
LGTM.
For me, the unit tests passed (in a couple of attempts) both before and after the change. However, I can definitely see how the "erase" can cause problems. And, I can see that removing the "erase" call won't noticeably change the behavior of the code since the full m_connection data member will be cleaned up after the destructor is finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can invalidate the iterators used for loop control.
Found because the ZmqPubSub unit test was failing. Don't know how it was missed before.