Explicitly set the TRACE_NAME in TLOG calls in several hxx files #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfreeman2
added a commit
that referenced
this pull request
Dec 13, 2023
Author: bieryAtFnal <36311946+bieryAtFnal@users.noreply.github.com>
Date: Thu Nov 30 09:56:07 2023 -0600
Merge pull request #69 from DUNE-DAQ/kbiery/tlog_trace_names
Explicitly set the TRACE_NAME in TLOG calls in several hxx files
jcfreeman2
added a commit
that referenced
this pull request
Dec 16, 2023
Date: Tue Dec 12 19:37:30 2023 -0600
syncing ; previous commit: Merge: 93f60ef 6a623b4
Author: bieryAtFnal <36311946+bieryAtFnal@users.noreply.github.com>
Date: Thu Nov 30 09:56:07 2023 -0600
Merge pull request #69 from DUNE-DAQ/kbiery/tlog_trace_names
Explicitly set the TRACE_NAME in TLOG calls in several hxx files
bieryAtFnal
added
the
miscellaneous deliverable
jcfreeman2
added a commit
that referenced
this pull request
Jan 8, 2024
Date: Fri Dec 15 18:06:57 2023 -0600
syncing ; previous commit: Author: John Freeman <jcfree@fnal.gov>
Date: Tue Dec 12 19:37:30 2023 -0600
syncing ; previous commit: Merge: 93f60ef 6a623b4
Author: bieryAtFnal <36311946+bieryAtFnal@users.noreply.github.com>
Date: Thu Nov 30 09:56:07 2023 -0600
Merge pull request #69 from DUNE-DAQ/kbiery/tlog_trace_names
Explicitly set the TRACE_NAME in TLOG calls in several hxx files
jcfreeman2
added a commit
that referenced
this pull request
Jan 9, 2024
…eman <jcfree@fnal.gov>
Date: Mon Jan 8 17:39:59 2024 -0600
syncing ; previous commit: Author: John Freeman <jcfree@fnal.gov>
Date: Fri Dec 15 18:06:57 2023 -0600
syncing ; previous commit: Author: John Freeman <jcfree@fnal.gov>
Date: Tue Dec 12 19:37:30 2023 -0600
syncing ; previous commit: Merge: 93f60ef 6a623b4
Author: bieryAtFnal <36311946+bieryAtFnal@users.noreply.github.com>
Date: Thu Nov 30 09:56:07 2023 -0600
Merge pull request #69 from DUNE-DAQ/kbiery/tlog_trace_names
Explicitly set the TRACE_NAME in TLOG calls in several hxx files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running tests of long-window readout with fddaq-v4.2.0 candidate builds, I noticed several TLOG messages showing up in the TRACE buffer with a TRACE_NAME of TPCTPRequestHandler which was clearly wrong because I didn't have TPG enabled. This turned out to be TLOG calls in hxx files that didn't have the TRACE_NAME explicitly set.
This PR is filed against the develop branch since it is not intended to be included in the 4.2 release.