Changes to verify that the HSIEvent Sender is really ready to send messages before completing the 'start' transition #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the HSIEventSender to be ready to send events (counting on the run start timeout from nanorc to kill things if it really goes on forever).
eflumerf
approved these changes
Sep 28, 2023
…or_ready_at_start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are candidate changes that make use of independent candidate changes in the
iomanagerrepo.The goal of these changes is to ensure that once a run is started, the FakeHSIEventGenerator is ready to start sending HSIEvents. This will prevent problems sending HSIEvents in the
do_hsi_work()method that are simply due to the Sender not being ready.The 'forever' loop waiting for the Sender to be ready might be too aggressive, and that can certainly be softened.