Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectivity service for application/controller control endpoint #71

Draft
wants to merge 44 commits into
base: develop
Choose a base branch
from

Conversation

plasorak
Copy link
Collaborator

@plasorak plasorak commented May 24, 2024

With this PR, the connectivity server is used advertise control endpoint for drunc-controller and daq_application.
Here is an example of how the connections are registered in the connectivity service:

hsi-controller_control: Connection(uri='grpc://10.73.136.38:5600', data_type='RunControlMessage', connection_type=0, time=datetime.datetime(2024, 10, 4, 17, 54, 25, 318840))
tp-stream-writer_control: Connection(uri='rest://10.73.136.38:5605', data_type='RunControlMessage', connection_type=0, time=datetime.datetime(2024, 10, 4, 17, 54, 25, 318840))

So data_types are RunControlMessages and the protocol of the URIs denotes the type of endpoint (gRPC or REST-API).

This allows dynamic port allocation for both the controllers and the applications, therefore remove the need to offset/change ports etc.

Related PRs:

Configurations don't necessary need to change but in that case they won't have dynamic port allocation for the control endpoint. Following are PRs where I have modified the control services in configuration:

  • listrev
  • daq-systemtest

@plasorak plasorak changed the title Application connectivity service Connectivity service for application/controller control endpoint Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants