Moved the stopping of the worker thread in the do_drain_dataflow() method of DQMProcessor… #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod after the lines of code that directly or indirectly make use of the TimestampEstimator instance (m_time_est pointer) since the worker function resets the m_time_est pointer as it finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…after the lines of code that directly or indirectly make use of the TimestampEstimator instance (m_time_est pointer) since the worker function resets the m_time_est pointer as it finishes.
I noticed this problem as part of testing the feature/tstamp_estimator_move changes. With those changes, the DQM part of the daq-systemtest/readout_type_scan integtest was failing because of a crash in the DQM_RU app.
With this additional change, I see the readout_type_scan integtest run successfully.