Make workorder-recheck work again

[TymurGubayev]

This repairs the workorder-recheck.lua script and adds an overlay to the work order conditions screen.

[myk002]

Welcome back! I've honestly missed your work!

[myk002]

this is the condition that would allow the overlay to be shown or the focus string to match below. I suppose it doesn't hurt terribly to check it again, but I don't think it's necessary.

[TymurGubayev]

I added it in case something went terribly wrong. I guess the only possible scenario is if the overlay would somehow be active when it shouldn't...

[myk002]

Though I understand the need for making this label short, "recheck" might be too short for players to grok. I'd want some input from people on the Discord server about what would be best here.

[myk002]

how about "re-check conditions" for this label? or maybe "request manager review"?

[TymurGubayev]

"request conditions re-check"?

[TymurGubayev]

or just "request re-check"?

[TymurGubayev]

I definitely want to keep the check there because it's everywhere on that screen

[myk002]

another option is the new widgets.TextButton that is designed to appear in more cramped spaces. It could fit in the single line directly above the active/inactive status icon.

screenshots of how that might look here: DFHack/dfhack#3655

example code: https://github.com/DFHack/dfhack/blob/9cb764b847f0dd0129e47d80b28e3c2c750b8738/plugins/lua/zone.lua#L1000

[TymurGubayev]

another option is the new widgets.TextButton that is designed to appear in more cramped spaces. It could fit in the single line directly above the active/inactive status icon.

is there a way to find where elements are on a screen? I discovered the tabs can be 1 or 2 lines, which makes positioning tricky

[TymurGubayev]

with default_pos={x=6,y=10}, and TextButton, it looks like this with two rows of tabs

but maximizing the DF window results in this:

[myk002]

You can try this:

• make the overlay 2 tiles tall (and don't specify a frame_background)
• on render, check the position of the status icon. If different from the last time you checked, adjust the TextButton frame and call updateLayout()

You can use dfhack.screen.readTile() to get what's on the screen at that position. The position you check should be relative to your overlay self.frame_rect (iirc)

[TymurGubayev]

that would work if readTile worked... Here is what I get for every coordinate:

[lua]# ~ dfhack.screen.readTile(10, 10, false)
userdata: 00000208D89089B8
bold = true
bg = 0
tile_color = false
ch = 0
fg = 7

And passing true returns the map tile.

Am I missing something?

[myk002]

Hmm, I'm not sure. What does devel/inspect-screen say for those tiles?

[myk002]

ha, oh I see:

the image is completely rendered in the lower layer, which readTile doesn't pick up. Let me see if I can extend readTile to work in that case

[myk002]

for now, you can test in ASCII mode, which works:

[myk002]

you know what, maybe test for text (the ch property) at coordinates (7,7). That will be a character from a tab label if there are two rows of tabs and will be blank otherwise.

edit: changed coordinates from (7, 8) to (7, 7) so the check will be the same in ascii mode

[myk002]

DFHack/dfhack#3670 will improve the readTile situation, but as I wrote above, I don't think you'll actually need it for this PR.

[TymurGubayev]

the textbox is now correctly positioned in all 4 cases ( { graphics, ASCII } x { one row, two rows} )

[myk002]

how about "re-check conditions" for this label? or maybe "request manager review"?

[myk002]

This is awesome. Thanks!