Give position.rst the "dfhack" tag; changes relating to active units #1308
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getUnitsInBox now only returns active units
Inactive units shouldn't use range if anybody updates this tool.
getUnitsInBox now returns active by default
Stray punctuation
|
you might want to move the parts that depend on DFHack/dfhack#4959 to another PR. 4959 might spark research and debate and might not get merged any time soon |
myk002
reviewed
Sep 28, 2024
| @@ -3,7 +3,7 @@ position | |||
|
|
|||
| .. dfhack-tool:: | |||
| :summary: Report cursor and mouse position, along with other info. | |||
| :tags: adventure fort inspection map | |||
| :tags: adventure dfhack fort inspection map | |||
There was a problem hiding this comment.
I updated the spreadsheet to reflect this: https://docs.google.com/spreadsheets/d/1hiDlo8M_bB_1jE-5HRs2RrrA_VZ4cRu9VXaTctX_nwk/edit?pli=1&gid=1774645373#gid=1774645373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give
positiontool thedfhacktag since it can be used to copy coords for other tools. (Need to update spreadsheet doc.)units.getUnitsInBoxwill already check for active units after DFHack/dfhack#4959 merges.Left a note in the
unavailablemodtools/reaction-trigger.luathat inactive unit positions are meaningless. (Should probably ignore range for these units and have some kind of filter?) If it's meant to work on corpses, you'd need to operate on items.Fixed a stray period in
exterminate.rst.