Position.lua: site/adv world coords #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Sep 4, 2024
position.lua
Outdated
| --TODO: print(' The fortress is at '..x, y..' on the world map ('..worldsize..' square)') | ||
| print(' The window is '..df.global.gps.dimx..' tiles wide and '..df.global.gps.dimy..' tiles high.') | ||
|
|
||
| if df.global.gps.mouse_x < 0 then |
There was a problem hiding this comment.
if we print out mouse cursor location, we should probably also print out the map coordinates of where the mouse is (dfhack.gui.getMousePos())
There was a problem hiding this comment.
Ended up putting this on a separate line. Let me know if it looks okay. It says "The mouse is" twice in a row, but that looks better than doing a comma+indent, IMO.
There was a problem hiding this comment.
Could also add an option to copy mouse tile position to clipboard. However there's limited feedback of where the mouse cursor is on the grid, and it would be difficult to use with the full launcher (which blocks most of the screen).
* Update position.lua * Update position.rst * Update changelog.txt
myk002
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print current site world coords, or adventurer (if applicable). Also swapped out uses of
math.floorfor//. Decreased padding zeros for current year from 5 to 3 digits (which is still sufficient to distinguish it from a month or day).Script is now tagged
adventure. It needs testing by someone on the adventurer beta. (Needs to be run inside site, outside site, travel mode, and dead.)Moved some changelog entries in the template section to the proper spot (if nobody fixes that before this PR merges).