some structure partially identified in assign_trade #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also gave the anons "real" names sorta
myk002
reviewed
Jun 29, 2023
| <stl-vector type-name='int16_t'/> | ||
| <stl-vector type-name='int32_t'/> | ||
| <stl-bit-vector/> | ||
| <stl-vector name='unk_a8'> |
There was a problem hiding this comment.
this is the vector I'd probably be accessing in the tool I'm working on (since I need to get at the referenced items). Could it possibly get a slightly more permanent name? like item_data or something?
There was a problem hiding this comment.
i'd like to have slightly more of an idea of what is in there before i give it even a semi-permanent name
keeping it as an unk signals that "this is not suitable for use in user-facing code" which it totally is not at this point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also gave the anons "real" names sorta
not important enough to changelog tbh