Support Rails >= 6.0 and Ruby >= 3 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bivanalhar
force-pushed
the
bivan/upgrade-rails-7-ruby-3
branch
6 times, most recently
from
6bdfe15
to
b037b0e
Compare
bivanalhar
force-pushed
the
bivan/upgrade-rails-7-ruby-3
branch
4 times, most recently
from
621c2c4
to
5de7cc0
Compare
bivanalhar
force-pushed
the
bivan/upgrade-rails-7-ruby-3
branch
from
f4a3a5e
to
5de7cc0
Compare
bivanalhar
changed the title
cysjonathan
requested changes
Jul 23, 2024
- ruby >= 3.0 and rails >= 6.0 - use Appraisal instead of travis chore(dep): modify rspec version for each rails ver
- sqlite3 to be constricted to ver 1.7
- run Dummy::Application instead of mere Rails - sprockets is no longer required in Rails 7, so assets config is removed - not raising transactional callbacks in current ActiveRecord version
- load models in spec/models instead of spec/dummy - restructure database_helpers
- refactor RESTFul API method inside spec - require all tables to be initialised properly before running spec - request.session code to be updated due to point-to-reference
bivanalhar
force-pushed
the
bivan/upgrade-rails-7-ruby-3
branch
from
7df1b53
to
7f8257d
Compare
cysjonathan
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is tested to be compatible so far: