Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ghcr.io/goreleaser/goreleaser-cross as an image for the go build in the docker #415

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Jun 12, 2024

Use ghcr.io/goreleaser/goreleaser-cross as image for the go build in docker

  • Use ghcr.io/goreleaser/goreleaser-cross image
  • Update the build config to allow passing of tags,ldFlags and docker volumes
  • Remove redundant code
  • Update wasmvm dependency

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

…docker

* Use ghcr.io/goreleaser/goreleaser-cross image
* Update the build config to allow passing of tags,ldFlags and docker volumes
* Remove redundant code
@dzmitryhil dzmitryhil requested a review from a team as a code owner June 12, 2024 11:15
@dzmitryhil dzmitryhil requested review from masihyeganeh, miladz68, ysv and wojtek-coreum and removed request for a team June 12, 2024 11:15
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh, @wojtek-coreum, and @ysv)

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, and @ysv)


build/golang/go.go line 50 at r2 (raw file):

	// Tags is go build tags.
	Tags []string

yay! I'm sooo happy seeing it back

@dzmitryhil dzmitryhil merged commit cf038db into master Jun 14, 2024
3 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/improve-coreum-cc branch June 14, 2024 10:31
@dzmitryhil dzmitryhil changed the title Use ghcr.io/goreleaser/goreleaser-cross as image for the go build in docker Use ghcr.io/goreleaser/goreleaser-cross as an image for the go build in the docker Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants