Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playground project #92

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Add playground project #92

merged 1 commit into from
Aug 6, 2024

Conversation

egorikftp
Copy link
Member

@Goooler
Copy link
Member

Goooler commented Aug 2, 2024

Is this playground essential?

@egorikftp
Copy link
Member Author

Is this playground essential?

If I add this, it's necessary 😄
I had a temporary project with icons and tested all changes on it. Now I'm going to use this one as "gold standard" + use it in new readme demo videos

playground/app/build.gradle.kts Outdated Show resolved Hide resolved
playground/app/src/main/res/values/colors.xml Outdated Show resolved Hide resolved
playground/gradle.properties Outdated Show resolved Hide resolved
playground/local.properties Outdated Show resolved Hide resolved
playground/settings.gradle.kts Outdated Show resolved Hide resolved
@Goooler
Copy link
Member

Goooler commented Aug 2, 2024

I had a temporary project with icons and tested all changes on it.

You may need test fixtures from test resources folder. If we add this sample project, you can also reuse those resources via source set addition.

@egorikftp egorikftp force-pushed the feature/add-playground-project branch from 60a1161 to 4724a3b Compare August 5, 2024 10:12
@egorikftp egorikftp marked this pull request as draft August 5, 2024 10:13
@egorikftp egorikftp force-pushed the feature/add-playground-project branch 3 times, most recently from 05c235e to 3a95f4e Compare August 5, 2024 10:21
@egorikftp
Copy link
Member Author

@Goooler we decided to add playground as nested application module and it will be available from run configuration 🙂

image

You may need test fixtures from test resources folder. If we add this sample project, you can also reuse those resources via source set addition.

I'm not sure if it's necessary at the moment since the tests contain "synthetic" icons specifically designed to check parsing and generation logic. Nonetheless, the playground is a working solution.

@Goooler
Copy link
Member

Goooler commented Aug 5, 2024

add playground as nested application module and it will be available from run configuration

This could be a include build, you can run the app from root project.

@egorikftp egorikftp force-pushed the feature/add-playground-project branch from 3a95f4e to 1ada28e Compare August 5, 2024 10:48
@egorikftp egorikftp marked this pull request as ready for review August 5, 2024 10:55
@egorikftp egorikftp force-pushed the feature/add-playground-project branch from 1ada28e to dfebf4a Compare August 5, 2024 13:45
@egorikftp egorikftp added this to the 0.5.1 milestone Aug 5, 2024
@egorikftp egorikftp merged commit 5046b3b into main Aug 6, 2024
2 checks passed
@egorikftp egorikftp deleted the feature/add-playground-project branch August 6, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants