Resolve OOM when process huge amount of icons #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
approved these changes
Jul 22, 2024
...o/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/IconPackConversionState.kt
Outdated
Show resolved
Hide resolved
...o/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/BatchProcessingState.kt
Outdated
Show resolved
Hide resolved
egorikftp
force-pushed
the
bugfix/resolve-oom-when-process-huge-amount-of-icons
branch
from
aeb3cf4
to
1e3de3c
Compare
|
@Goooler Added new progress states 🙂 Screen.Recording.2024-07-23.at.11.24.48.mov |
Goooler
reviewed
Jul 23, 2024
...o/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/IconPackConversionState.kt
Outdated
Show resolved
Hide resolved
Goooler
approved these changes
Jul 23, 2024
egorikftp
force-pushed
the
bugfix/resolve-oom-when-process-huge-amount-of-icons
branch
from
1e3de3c
to
e466172
Compare
Goooler
approved these changes
Jul 23, 2024
egorikftp
deleted the
bugfix/resolve-oom-when-process-huge-amount-of-icons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #36
demo:
2024-07-22.23.10.58.mp4