Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ImageVectorPreviewEditorProvider to preview ImageVector inside kt file #136

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

egorikftp
Copy link
Member

@egorikftp egorikftp commented Aug 20, 2024

Basic logic for parsing is done and can be reviewed 🎉
Ref: #132

Introduces "components:ir" module as "intermediate representation" for image vector.
Later will be applied to "components:androidx-compose" module and replace existing classes.

Screen.Recording.2024-08-21.at.08.48.47.mp4

TODO:

  • Add parsing for lazy block
  • Fix tests on Windows machine

@egorikftp egorikftp added this to the 0.7 milestone Aug 20, 2024
@egorikftp egorikftp force-pushed the feature/imagevector-studio-preview branch 5 times, most recently from 08f65fd to 1f9a669 Compare August 21, 2024 06:01
@egorikftp egorikftp force-pushed the feature/imagevector-studio-preview branch from 1f9a669 to 3598af6 Compare August 21, 2024 08:55
@egorikftp egorikftp removed the request for review from vkatz August 22, 2024 02:52
@egorikftp
Copy link
Member Author

@Goooler if your have a time, could you please review? Looks like this part finalized

Copy link
Member

@Goooler Goooler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No much experience with PSI.

@egorikftp egorikftp merged commit ad2eefb into main Aug 22, 2024
2 checks passed
@egorikftp egorikftp deleted the feature/imagevector-studio-preview branch August 22, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants