Contact duration and distance #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causing problems with CI, reason unclear as it's supposed to also use MacOs This reverts commit b48a649.
ivnsch
force-pushed
the
feature/duration-distance
branch
from
c5b14b7
to
040155e
Compare
|
@i-schuetz Ups, I noticed its a draft PR only after I have gone through the whole thing :( |
duskoo
reviewed
Jul 15, 2020
ivnsch
force-pushed
the
feature/duration-distance
branch
from
59b336c
to
6638b99
Compare
ivnsch
force-pushed
the
feature/duration-distance
branch
from
6638b99
to
18e5f6b
Compare
ivnsch
force-pushed
the
feature/duration-distance
branch
from
18e5f6b
to
076a86b
Compare
ivnsch
force-pushed
the
feature/duration-distance
branch
from
1ed3f93
to
2e2077a
Compare
ivnsch
force-pushed
the
feature/duration-distance
branch
from
2275ba7
to
a8049aa
Compare
duskoo
reviewed
Jul 16, 2020
ivnsch
force-pushed
the
feature/duration-distance
branch
from
3b39c97
to
6f72b45
Compare
ivnsch
force-pushed
the
feature/duration-distance
branch
from
cb13cb7
to
3ff6f0a
Compare
Should be better for performance
ivnsch
commented
Jul 17, 2020
duskoo
approved these changes
Jul 18, 2020
| Some(merged ) => vec![merged], | ||
| None => vec![last.to_owned(), tcn] | ||
| }; | ||
| let mut head: Vec<ObservedTcn> = db_tcns.to_owned().into_iter().take(db_tcns.len() - 1).collect(); |
There was a problem hiding this comment.
We could avoid iterating over the vector and just replace the last element: https://doc.rust-lang.org/std/mem/fn.replace.html
There was a problem hiding this comment.
Unclear how mem::replace helps. It seems to replace the complete vector. db_tcns is also unlikely to contain more than a couple of elements (these are the stored, averaged exposures for an individual TCN) so the performance is negligible.
There was a problem hiding this comment.
mem::replace works on a vector element.
Good point regarding small vector size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.