Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up container labels, creation #233

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Clean up container labels, creation #233

merged 2 commits into from
Aug 10, 2023

Conversation

brews
Copy link
Member

@brews brews commented Aug 9, 2023

Extension of PR #195, this cleans up container building and metadata. before containers are published.

  • Consolidate CI workflows publishing the container into single workflow (.github/workflows/container-publish.yaml).
  • Bleeding-edge development now uses edge tag instead of dev tag, following best practice.
  • Use docker/metadata-action to set container labels rather than setting them manually.

@brews brews added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 9, 2023
@brews brews self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #233 (c853fd6) into main (1564ff3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files           8        8           
  Lines        1352     1352           
=======================================
  Hits         1208     1208           
  Misses        144      144           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@brews brews marked this pull request as ready for review August 10, 2023 00:14
@brews brews merged commit 45cbe36 into main Aug 10, 2023
6 checks passed
@brews brews deleted the container_publish branch August 10, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant