Skip to content

Commit

Permalink
fix typo in cubic_vsat methods
Browse files Browse the repository at this point in the history
  • Loading branch information
longemen3000 committed Feb 25, 2024
1 parent d0aefd0 commit 4adc604
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "EoSSuperancillaries"
uuid = "c1bf003f-4e47-49d9-bdfd-5a4051db3c04"
authors = ["Pierre Walker <pjwalker@caltech.edu>", "Andrés Riedemann <andres.riedemann@gmail.com>"]
version = "1.2.2"
version = "1.2.3"

[deps]
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
Expand Down
2 changes: 1 addition & 1 deletion src/Cubic/cubic.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ function _cubic_vsat(T,a,b,CV)
return b/ρ
end

function _cubic_vsat2(T,a,b,CV,VL)
function _cubic_vsat2(T,a,b,CL,CV)
= T**b/a
ρl = cheb_eval(CL,T̃)
ρv = cheb_eval(CV,T̃)
Expand Down
2 changes: 2 additions & 0 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ using EoSSuperancillaries: cheb_eval
@test cheb_eval(ES._pr_p(),T̃) 0.003034198868923775
@test cheb_eval(ES._pr_vl(),T̃) 0.6394564580846998
@test cheb_eval(ES._pr_vv(),T̃) 0.03023195086998487
#tcPR values for water, minus translation
@test pr_vsat(373.15,0.872992520895242,1.8970393160040243e-5)[1] 2.2534096665506367e-5
end
# Write your tests here.
end
Expand Down

2 comments on commit 4adc604

@longemen3000
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/101606

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.2.3 -m "<description of version>" 4adc604ce74069f3801e8faf175d765b1855ec98
git push origin v1.2.3

Please sign in to comment.