Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form components: fixes and improvements to IconButton, Checkbox, Radio, Switch and Autocomplete #883

Merged
merged 20 commits into from
Jun 26, 2024

Conversation

Copy link

github-actions bot commented Jun 21, 2024

Visit the preview URL for this PR (updated for commit 55e7888):

https://cartodb-fb-storybook-react-dev--pr883-feature-forms-fi-fwuoe6ie.web.app

(expires Tue, 02 Jul 2024 16:19:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9611568366

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%

Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635

💛 - Coveralls

Copy link

Pull Request Test Coverage Report for Build 9644266620

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%

Totals Coverage Status
Change from base Build 9642425042: 0.0%
Covered Lines: 2811
Relevant Lines: 3635

💛 - Coveralls

2 similar comments
Copy link

Pull Request Test Coverage Report for Build 9644266620

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%

Totals Coverage Status
Change from base Build 9642425042: 0.0%
Covered Lines: 2811
Relevant Lines: 3635

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9644266620

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%

Totals Coverage Status
Change from base Build 9642425042: 0.0%
Covered Lines: 2811
Relevant Lines: 3635

💛 - Coveralls

Copy link

Pull Request Test Coverage Report for Build 9644386493

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.05%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

2 similar comments
Copy link

Pull Request Test Coverage Report for Build 9644386493

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.05%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

Copy link

Pull Request Test Coverage Report for Build 9644386493

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.05%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

Copy link

Pull Request Test Coverage Report for Build 9644491738

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.05%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

2 similar comments
Copy link

Pull Request Test Coverage Report for Build 9644491738

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.05%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9644491738

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.05%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

Copy link

Pull Request Test Coverage Report for Build 9660127195

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.03%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

Copy link

Pull Request Test Coverage Report for Build 9660127195

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.03%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

1 similar comment
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9660127195

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.03%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

Copy link

Pull Request Test Coverage Report for Build 9664573649

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.03%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

1 similar comment
@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9664573649

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9642425042: 0.03%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

@vmilan vmilan changed the title Forms fixes & improvements Form components: fixes and improvements to IconButton, Checkbox, Radio, Switch and Autocomplete Jun 25, 2024
@vmilan vmilan requested review from Josmorsot, AlvaroAlmonacidRojo and a team June 25, 2024 16:14
@vmilan vmilan marked this pull request as ready for review June 25, 2024 16:14
Copy link

Pull Request Test Coverage Report for Build 9665977914

Details

  • 3 of 7 (42.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 71.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
packages/react-ui/src/theme/sections/components/forms.js 2 5 40.0%
Totals Coverage Status
Change from base Build 9642425042: -0.05%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

2 similar comments
Copy link

Pull Request Test Coverage Report for Build 9665977914

Details

  • 3 of 7 (42.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 71.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
packages/react-ui/src/theme/sections/components/forms.js 2 5 40.0%
Totals Coverage Status
Change from base Build 9642425042: -0.05%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9665977914

Details

  • 3 of 7 (42.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 71.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
packages/react-ui/src/theme/sections/components/forms.js 2 5 40.0%
Totals Coverage Status
Change from base Build 9642425042: -0.05%
Covered Lines: 2814
Relevant Lines: 3639

💛 - Coveralls

Copy link
Contributor

@jmgaya jmgaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Copy link
Contributor

@Josmorsot Josmorsot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmilan vmilan merged commit d0ffd5a into master Jun 26, 2024
2 checks passed
@vmilan vmilan deleted the feature/forms-fixes-ii branch June 26, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants