fix(core): Add getUTCMonday, fix tests in U.S. timezone #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9505380995Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9505380995Details
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit 0e81c14): https://cartodb-fb-storybook-react-dev--pr879-fix-timezone-agn-tzpdwud3.web.app (expires Fri, 21 Jun 2024 13:34:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
Pull Request Test Coverage Report for Build 9505380995Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9505453641Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9505453641Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9505453641Details
💛 - Coveralls |
vmilan
reviewed
Jun 14, 2024
There was a problem hiding this comment.
Please, add an entry to the changelog on every PR 🙏
I added for you the last one that was missing, here: https://github.com/CartoDB/carto-react/pull/881/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
jmgaya
approved these changes
Jun 14, 2024
donmccurdy
force-pushed
the
fix/timezone-agnostic-week-counts
branch
from
f960e9c
to
0e81c14
Compare
|
@vmilan changelog updated, thank you! |
Pull Request Test Coverage Report for Build 9516971163Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9516971163Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9516971163Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the tests do not pass when running locally from a U.S. time zone, fixed in this PR. Existing code in
groupByDate.jsused UTC time for all groupings, andTimeSeriesWidgetuses local time, but both call intogetMondaywhich cannot do both ... so I think it's likely that a UTC-specific version ofgetMondayis required.Changes: