New DS core components: Menu & MenuItem #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9349880137Details
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit 1ac01a6): https://cartodb-fb-storybook-react-dev--pr870-feature-ds-menu-r8e6x0dn.web.app (expires Mon, 10 Jun 2024 12:16:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
vmilan
requested review from
VictorVelarde,
Josmorsot,
AlvaroAlmonacidRojo and
a team
AlvaroAlmonacidRojo
approved these changes
May 23, 2024
vmilan
changed the title
| @@ -25,6 +25,9 @@ const StyledSelect = styled(Select)(({ theme }) => ({ | |||
| }, | |||
| '& .MuiSelect-select .MuiMenuItem-root:hover': { | |||
| backgroundColor: 'transparent' | |||
| }, | |||
| '&.MuiInputBase-root .MuiSelect-select.MuiSelect-multiple': { | |||
| paddingRight: theme.spacing(7) | |||
There was a problem hiding this comment.
Looks (potentially) a bit risky for current use cases... isn't it?
There was a problem hiding this comment.
It applies only to multiple selection case, and we need it globally for this use case 👍
VictorVelarde
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/292331/core-new-component-menu-dropdown
[sc-292331]