TimeSeriesWidget: fix echarts props update, to keep state of control when clicking #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbigg
force-pushed
the
zbigg/fix-timeseries-reset-on-click
branch
from
da2bf87
to
65826e7
Compare
Pull Request Test Coverage Report for Build 8753292311Details
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit 612b93c): https://cartodb-fb-storybook-react-dev--pr865-zbigg-fix-timese-mj6tc0du.web.app (expires Fri, 26 Apr 2024 12:16:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
…on each prop change
zbigg
force-pushed
the
zbigg/fix-timeseries-reset-on-click
branch
from
65826e7
to
2a735e2
Compare
zbigg
force-pushed
the
zbigg/fix-timeseries-reset-on-click
branch
from
2a735e2
to
6f64967
Compare
zbigg
commented
Apr 19, 2024
| @@ -197,6 +197,7 @@ export default function TimeSeriesChart({ | |||
| : theme.palette.action.disabledBackground; | |||
|
|
|||
| return { | |||
| id: name, | |||
There was a problem hiding this comment.
This ensures that echarts keeps track of series when we update data.
zbigg
commented
Apr 19, 2024
| const { option, lazyUpdate, showLoading, loadingOption = null } = this.props; | ||
| const echartInstance = this.getEchartsInstance(); | ||
|
|
||
| echartInstance.setOption(option, { replaceMerge: ['series'], lazyUpdate }); |
There was a problem hiding this comment.
This ensures that merges series objects as list identified by id
zbigg
commented
Apr 19, 2024
| const updateTimelineByCoordinate = useCallback( | ||
| (params) => { | ||
| if (echartsInstance) { | ||
| const [x] = echartsInstance.convertFromPixel({ seriesIndex: 0 }, [ | ||
| const [x] = echartsInstance.convertFromPixel(seriesFinder, [ |
There was a problem hiding this comment.
When we remove series from beginnning (by filtering sql by param), internal echarts array looks this: [undefined, undefined, something, something ]
So seriesIndex: 0 doesn't always work. Solution: find by category name
padawannn
approved these changes
Apr 19, 2024
zbigg
added a commit
that referenced
this pull request
Apr 22, 2024
Merged
zbigg
added a commit
that referenced
this pull request
Apr 22, 2024
* TimeSeriesWidget: fix echarts props update, to keep state of control when clicking (#865)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/404593/builder-timeserieswidget-tooltip-disappears-when-clicking-on-series
In
TimeseriesWidget, fix way we update props inechartsinstance so(note, data update still resets control animation/filter state)
Fixes regression from #863
Type of change
Acceptance
Please describe how to validate the feature or fix
If feature deals with theme / UI or internal elements used also in CARTO 3, please also add a note on how to do acceptance on that part.
Basic checklist