Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MultipleSelectField placeholder text color #846

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

Shylpx
Copy link
Contributor

@Shylpx Shylpx commented Mar 5, 2024

Description

Update the color of MultipleSelectField text placeholder to match the design

Type of change

  • Fix

Acceptance

  • Before
    Screenshot from 2024-03-05 15-32-46

  • After
    Screenshot from 2024-03-05 15-32-19

@Shylpx Shylpx requested a review from vmilan March 5, 2024 15:28
Copy link
Contributor

@vmilan vmilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Mar 5, 2024

Pull Request Test Coverage Report for Build 8158837219

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.559%

Totals Coverage Status
Change from base Build 8154306142: 0.0%
Covered Lines: 2626
Relevant Lines: 3489

💛 - Coveralls

Copy link

github-actions bot commented Mar 5, 2024

Visit the preview URL for this PR (updated for commit 794da54):

https://cartodb-fb-storybook-react-dev--pr846-cgonzalez-fix-fo-ole0tp6d.web.app

(expires Tue, 12 Mar 2024 15:36:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@Shylpx Shylpx merged commit 23d543a into master Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants