Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forced number casting for aggregations #735

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Forced number casting for aggregations #735

merged 4 commits into from
Jul 6, 2023

Conversation

VictorVelarde
Copy link
Contributor

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #305734: [ac_iadb63gg] Big numeric columns are handled like strings.

@VictorVelarde VictorVelarde requested review from Shylpx and removed request for Shylpx July 6, 2023 16:21
@VictorVelarde
Copy link
Contributor Author

some pending work in tests... wip

@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5478015171

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 71.622%
Totals Coverage Status
Change from base Build 5467060378: -0.003%
Covered Lines: 2260
Relevant Lines: 2924
💛 - Coveralls

@VictorVelarde VictorVelarde requested a review from Shylpx July 6, 2023 16:45
@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit b2212de):

https://cartodb-fb-storybook-react-dev--pr735-force-numbers-fo-x5e07lun.web.app

(expires Thu, 13 Jul 2023 16:56:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@VictorVelarde VictorVelarde merged commit a288182 into master Jul 6, 2023
1 check passed
@VictorVelarde VictorVelarde deleted the force-numbers-for-formula-widget branch July 6, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shylpx Shylpx Awaiting requested review from Shylpx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VictorVelarde