Fix blank map when loading widgets for tilesets #733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change now
data
can benull
, so this breaks some widgets (like CategoryWidget, or HistogramWidget), when they access to the.length
propertly.In the past, we were ignoring
undefined
andnull
values, andundefined
works fine because a default empty array is used. However, fornull
values, the map crashes. I was able to reproduce it with tilesets using category and histogram widgets, when we are dropping features.Type of change
Acceptance